Bug #1002
closednavigator final image shift uses image shift of the parent preset plus the final image shift
0%
Description
See 10nov05b_00005hl_v01.mrc
The target is chosen on the hl image (504,184), the navigator did move the stage to approximately the target with 7.5e-8 m move error. However, an image shift of (1.2e-6,-1.4e-6) is applied to the en (0,0) preset,
This might be related the navigation error reported by Dmitry and Scott
Updated by Jim Pulokas over 13 years ago
still searching for the cause, but I am pretty sure it has something to do with navigator assuming that the current preset is the parent image preset (hl in this case). This would be true for the first target on the hl image because it was just at hl, but for all other targets, the current preset is probably en.
Updated by Jim Pulokas over 13 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Jim Pulokas to Anchi Cheng
r15005 adds preset change before anything else happens. That way presets manager will know what navigator has done.
Updated by Jim Pulokas over 13 years ago
I tested using SimTEM/SimCCDCamera, and this seems to fix the problem. Now for all en images, the image shift reported in the database only includes the amount of the final image shift done by navigator. Before the fix, the en image shift included the hl preset image shift + the final image shift done by navigator (except for the first target, which always worked)
Updated by Anchi Cheng over 13 years ago
- Status changed from In Code Review to Closed
reviewed and tested with r15019 debug. This fix causes some problem with preset image alignment and other things that moved with navigator. Will open a separate issue and fix them there.
Updated by Anchi Cheng over 13 years ago
- Category set to Leginon subsystem
- Status changed from Closed to In Code Review
- Assignee changed from Anchi Cheng to Jim Pulokas
- Priority changed from Immediate to High
- Target version set to Appion/Leginon 2.1.1
modify presets.py in r15023 so that cycleToScope does not try to change scope condition while navigator.moveToTarget is trying to do the same. Also use _cycleToScope instead of cycleToScope to avoid sending self.panel.presetsEvent()
The changes from this bug fix will need to be merged into 2,0 and 2.1
Updated by Anchi Cheng over 13 years ago
- Subject changed from navigator final image shift does not take into account of the move to navigator final image shift uses image shift of the parent preset plus the final image shift
Updated by Anchi Cheng over 13 years ago
merge changes from the three revisions to branch 2.1 as r15051. Tested
Updated by Anchi Cheng over 13 years ago
- Status changed from In Code Review to Closed
- Affected Version changed from Appion/Leginon 2.1.0 to Appion/Leginon 2.0.0
r15052 merges the same changes to branch 2,0
tested.