Project

General

Profile

Actions

Bug #1097

closed

runClusterCoran.php does not produce runname in its command

Added by Anchi Cheng over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/16/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

r15151 removed the runname variable pulled from the feature analysis. In this special case, the clustering and the feature analysis use the same runname.

Actions #1

Updated by Anchi Cheng over 13 years ago

  • Status changed from Assigned to In Code Review
  • Assignee set to Lauren Fisher

put that part back.

Actions #2

Updated by Lauren Fisher over 13 years ago

I see what I did wrong here...I moved that section to the function above so that it would set the default output directory, but I shouldn't have removed it from the second function because runname wasn't set anymore. However, if feature analysis and clustering need the same runname and need to be in the same directory, do we even want the output directory to be editable by the user? This is probably another one of those cases where it is too dangerous to give them that ability because if they don't know the directories need to be the same, it will cause problems. Should I reset runClusterCoran.php to the original so outdir is not an option on the page?

Actions #3

Updated by Lauren Fisher over 13 years ago

r15200 reset the variables under the function runClusterCoran to the original format, disabled the output directory so the user can see it, but can not edit it since it has to be the same for clustering and feature analysis, and added a note under the output directory explaining why it's disabled.

Actions #4

Updated by Lauren Fisher over 13 years ago

  • Assignee changed from Lauren Fisher to Anchi Cheng
Actions #5

Updated by Anchi Cheng over 13 years ago

  • Status changed from In Code Review to Closed

code reviewed and tested

Actions

Also available in: Atom PDF