Project

General

Profile

Actions
Copy link

Bug #1294

closed

Divsion by zero error in runMakeStack2.php

Added by Lauren Fisher about 13 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
Appion/Leginon 2.2.0
Start date:
05/10/2011
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

runMakeStack2.php fails to calculate the pixel size on manually collected images. It runs into an error when determining the default boxsize because it is trying to divide by zero. It displays 2 ugly warnings on the stack creation web form and sets boxsize to 4 pixels. 

Warning: Division by zero in /srv/www/html/betamyamiweb/processing/runMakeStack2.php on line 383

Warning: Division by zero in /srv/www/html/betamyamiweb/processing/runMakeStack2.php on line 385

This doesn't prevent the user from changing the boxsize and still creating a stack, but I think the getPixelSizeFromImgId function in particledata.inc needs to find the pixel size in a better way that doesn't fail on manually collected leginon data.

Actions
Copy link
 #1

Updated by Anchi Cheng about 12 years ago

  • Status changed from New to In Code Review
  • Assignee set to Amber Herold
  • Target version set to Appion/Leginon 2.2.0

r16500 use ScopeEMData and CameraEMData directly from the image to get pixel size if the one using preset fails. I didn't want to use the new query all the time in case it is slower by needing more joins.

Actions
Copy link
 #2

Updated by Amber Herold about 10 years ago

  • Status changed from In Code Review to Closed
Actions
Copy link

Also available in: Atom PDF