Bug #1532
openselectPreparedRecon.php gives 1x when imported parameters from a previous recon are null
0%
Description
For example, choosing eman_recon2 and use 12jan12z as template parameters at the page below gives quite a few of these, including resolution filter at the bottom of the left column. In 12jan12z, these parameters were imported from GroEL with 10,000 particles
myamiweb/processing/selectPreparedRecon.php?expId=9441
Updated by Anchi Cheng over 12 years ago
- Affected Version changed from Appion/Leginon 2.1.0 to Appion/Leginon 2.2.0 (trunk)
Updated by Amber Herold over 12 years ago
- Assignee changed from Amber Herold to Anchi Cheng
Looks like I did that on purpose; here is my comment from the code:
// NULL values should be added as empty, in case
// early iterations are NULL and later ones are set.
//if ( $newIterValue == NULL ) return;
I commented out the return on NULL to allow early iterations to be null with later iterations non-null.
Would you like me to add some code to remove parameters that only have null values after all iterations have been considered? Or is it better to leave it how it is to show that the parameter was not set for any of the iterations in the selected refinement?
Updated by Anchi Cheng over 12 years ago
- Assignee changed from Anchi Cheng to Amber Herold
I am not aware that we have cases of changing from null to not null at different iteration. Did one of the users request this?
It would be worth while checking what XMIPPS do in this case since this style is based on their syntax. I don't think python parser that we use can handle this. You will have to make python parser take default when it is written as "1x" if you want to keep this behavior.
Updated by Amber Herold about 12 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Amber Herold to Anchi Cheng