Project

General

Profile

Actions

Feature #1557

closed

break up makestack2.py to extract particledata from images and making stack

Added by Anchi Cheng about 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Python scripting
Target version:
Start date:
02/16/2012
Due date:
% Done:

0%

Estimated time:

Description

Want to create a base class that only extract particledata according to all the criteria of the current makestack2.py so that we can use them for other kind of particle processing.

Actions #1

Updated by Anchi Cheng about 12 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Gabriel Lander

r16337 added apParticleExtractor.py to appionlib and move all image and particle elimination functions there.

Gabe, I assign to you to code-review since you last worked on it. If you can't do it, assign it to someone else.

Assign Lauren to test since I didn't test the helical stack making.

Actions #2

Updated by Gabriel Lander about 12 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Gabriel Lander to Lauren Fisher

Anchi, this all looks good - great work. It's about time we started breaking up this huge function into more manageable components. The only thing I did was to make a small "getCS" function inside makestack, since we keep doing it over and over. Should be ready for testing.
r16352

Actions #3

Updated by Amber Herold about 12 years ago

Lauren, do you think you will get a chance to test this in the next few days? if not, I'll assign to someone else. Getting ready for 2.2 release...

Actions #4

Updated by Lauren Fisher about 12 years ago

  • Status changed from In Test to Closed

I ran it on Guppy with various parameters and everything tested fine for me. Looks like its good to go!

Actions

Also available in: Atom PDF