Bug #1795: manual focus tool in focuser should not use the first preset in preset order - Leginon - Electron Microscopy Group

Actions

Copy link

Bug #1795

closed

manual focus tool in focuser should not use the first preset in preset order

Added by Anchi Cheng about 12 years ago. Updated about 12 years ago.

Status:

Closed

Priority:

Urgent

Assignee:

Anchi Cheng

Category:

Leginon subsystem

Target version:

Appion - Appion/Leginon 2.2.0

Start date:

05/14/2012

Due date:

% Done:

Estimated time:

Affected Version:

Appion/Leginon 2.2.0 (trunk)

Show in known bugs:

Workaround:

Description

This is a problem when manual focus should be done with survey camera on DD which does not have a valid matrix calibration. When image shift is used as move type, it uses first preset in preset order to determine the transformation of the target. The two usage conflict with each other.

Will create a new settings for manual focus. Need dbschema update for all users. and need to be in 2.2

Actions

Copy link

Updated by Anchi Cheng about 12 years ago

Category set to Leginon subsystem
Status changed from Assigned to In Code Review
Assignee changed from Anchi Cheng to Jim Pulokas

r16607 adds the choice and gui to leginon
r16616 adds the dbschema that copies first preset order to this new function so that it does not break.

Actions

Copy link

Updated by Jim Pulokas about 12 years ago

Status changed from In Code Review to In Test
Assignee changed from Jim Pulokas to Anchi Cheng

reviewed and it looks good. It seems obvious to us, but we may need to put in documentation an explanation that "Manual focus tool preset" only applies to the "MF" button, not to the manual focus that pops up when you have manual focus in the sequence, which has its own preset.

Actions

Copy link