Project

General

Profile

Actions
Copy link

Bug #358

closed

CTF confidence value histogram not appearing on amilab16

Added by Anna-Clare Milazzo about 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
Appion/Leginon 2.0.0
Start date:
04/16/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Show in known bugs:
Workaround:

Description

When using Appion from amilab16 the histogram of confidence values is not appearing when it used to.

http://amilab16.scripps.edu/myami/processing/ctfreport.php?expId=7486

Actions
Copy link
 #1

Updated by Eric Hou about 14 years ago

  • Status changed from New to In Code Review
  • Assignee changed from Eric Hou to Amber Herold

There is a problem on checking out the php error message. First pregmatch function should be preg_match. And there is not CATCH_PHPERRMSG constant get defined.
I just comment out this three lines now to make it work.

Actions
Copy link
 #2

Updated by Amber Herold about 14 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Amber Herold to Neil Voss
  • Target version set to Appion/Leginon 2.0.0

r13557

I really don't like the idea of reducing the level of error checking to fix a problem. Neil, do you see any problem with this and can you test it?

Actions
Copy link
 #3

Updated by Neil Voss about 14 years ago

  • Assignee changed from Neil Voss to Eric Hou

I think we had no clue what the error check was for, but it broke things. Or maybe it has to php_errormsg NOT phperrormsg. Check with Eric.

Actions
Copy link
 #4

Updated by Eric Hou about 14 years ago

  • Assignee changed from Eric Hou to Amber Herold
  • % Done changed from 0 to 100

The problem was there were syntax error in the code. The person who put this extra error checking wasn't actually do it right, so I don't know what error he was try to catch.

We did not write this code, it was download from other open source project. People just add extra error checking for their own good. So don't waste time for this unless you have nothing to do or you have some better ideas to solve it.

Thanks.

Eric

Actions
Copy link
 #5

Updated by Amber Herold about 14 years ago

  • Status changed from In Test to Closed
Actions
Copy link

Also available in: Atom PDF