Bug #384
closedpage.php&pId=7 should be more descriptive like page.php&projectId=7
100%
Description
I want to change this and then add some feature such that if the expId is missing the menu will still show up with projectId info.
Updated by Anchi Cheng about 14 years ago
Can we keep it a bit shorter such as projId instead of projectId?
Updated by Neil Voss about 14 years ago
Alright projectId it is. Glad we are all in agreement.
Updated by Neil Voss about 14 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Neil Voss to Amber Herold
- % Done changed from 0 to 100
changed looked for bug, but more may come up.
Updated by Amber Herold about 14 years ago
- Assignee changed from Amber Herold to Neil Voss
in getpreset.php check reference to Apix at line 60.
Processing.inc removes a get and post. intentional?
prtlreport.php and maskreport.php have all sorts of changes that don't appear related to the projectId name change. Are they intended?
Updated by Neil Voss about 14 years ago
- Assignee changed from Neil Voss to Amber Herold
revert in r13621.
Updated by Neil Voss about 14 years ago
Changes to processing.inc remove checks for $_GET[pid] and $_POST[projectid] with lowercase 'I'.
prtlreport.php had a bunch of legacy code that no longer worked or did anything, so it was cleaned up. maskreport.php copied the legacy code from prtlreport.php which only applied to particles anyway, so it was also removed.
Updated by Amber Herold about 14 years ago
- Assignee changed from Amber Herold to Neil Voss
How to test?
Updated by Neil Voss about 14 years ago
- Assignee changed from Neil Voss to Amber Herold
I do not know a great test, but play around in the project pages to make sure the projectId is retained in the url above.
Updated by Amber Herold about 14 years ago
- Status changed from In Code Review to Closed
Testing for this should be included in what is already happening for Appion 2.0 release.