Project

General

Profile

Actions
Copy link

Bug #413

closed

hierarchClusterProcess threshold is dependent on spider version

Added by Gabriel Lander about 14 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Anke Mulder
Category:
-
Target version:
Appion/Leginon 2.0.0
Start date:
05/01/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Show in known bugs:
Workaround:

Description

The "hierarchClusterProcess" function in "classification.py" needs to check which version of spider is installed before determining the threshold.
For spider releases after 6/11/09, the functions "CL HE" and "CL HD" use values from 0-100, whereas before this release the values are from 0-1. This affects all scripts that use coran.
Is there any function in the apSpider lib to get the spider version?

Actions
Copy link
 #1

Updated by Neil Voss about 14 years ago

  • Subject changed from appionlib/apSpider/classification.py to hierarchClusterProcess threshold is dependent on spider version
  • Status changed from New to Assigned
  • Assignee set to Neil Voss
Actions
Copy link
 #2

Updated by Neil Voss about 14 years ago

Added function that gets SPIDER version to spyder.py, tested on SPIDER versions: 13.0, 14.18, and 15.12.

Actions
Copy link
 #3

Updated by Neil Voss about 14 years ago

  • Assignee changed from Neil Voss to Gabriel Lander

Gabe do we know which version requires this switch. versions 13 to 15 uses the less than one system. How about 16,17,18?

When done we will add:

sp = spyder.SpiderSession()
if sp.version() >= 16.0:
  thresh *= 100.0

or something

Actions
Copy link
 #4

Updated by Neil Voss about 14 years ago

  • % Done changed from 0 to 50
Actions
Copy link
 #5

Updated by Gabriel Lander about 14 years ago

Looks like this scaling was introduced in release 18.03

Actions
Copy link
 #6

Updated by Gabriel Lander about 14 years ago

  • Status changed from Assigned to In Test
  • Assignee changed from Gabriel Lander to Neil Voss

added version check to code, works at this end.
r13890

Actions
Copy link
 #7

Updated by Neil Voss almost 14 years ago

  • Target version set to Appion/Leginon 2.0.0
Actions
Copy link
 #8

Updated by Neil Voss almost 14 years ago

  • Assignee deleted (Neil Voss)
Actions
Copy link
 #9

Updated by Neil Voss almost 14 years ago

  • % Done changed from 50 to 100
Actions
Copy link
 #10

Updated by Neil Voss almost 14 years ago

  • Assignee set to Anke Mulder

Anke is testing today with SPIDER 18.

Actions
Copy link
 #11

Updated by Anke Mulder almost 14 years ago

  • Status changed from In Test to Closed

Fixed. Runs!!!!

Actions
Copy link

Also available in: Atom PDF