Project

General

Profile

Actions

Bug #4720

closed

Makestack not working

Added by William Rice over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
01/25/2017
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.3
Show in known bugs:
No
Workaround:

Description

Making stack crashes, either boxfiles only or to make actual stack. This is after latest update, working yesterday
Session 17jan23d, name stack5.appionsub.job

Beginning Main Loop 
... Pixel size: 0.854905 
... Found 334 particles 
1 
Traceback (most recent call last): 
File "/opt/myamisnap/bin/makestack2.py", line 1325, in  
makeStack.run() 
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 88, in run 
results = self.loopProcessImage(imgdata) 
File "/opt/myamisnap/lib/appionlib/appionLoop2.py", line 146, in loopProcessImage 
return self.processImage(imgdata) 
File "/opt/myamisnap/lib/appionlib/apParticleExtractor.py", line 531, in processImage 
total_processed_particles = self.processParticles(imgdata,partdatas,shiftdata) 
File "/opt/myamisnap/bin/makestack2.py", line 126, in processParticles 
self.boxedpartdatas, self.imgstackfile, self.partmeantree = self.boxParticlesFromImage(imgdata, partdatas, 
shiftdata) 
File "/opt/myamisnap/bin/makestack2.py", line 269, in boxParticlesFromImage 
partdatas, shiftdata, boxfile, rotate=self.params['rotate'], checkInside=self.params['checkInside']) 

TypeError: processParticleData() got an unexpected keyword argument 'checkInside' 


Related issues 1 (1 open0 closed)

Related to Appion - Bug #4842: makestack with only boxfiles checked, produces no boxfilesIn Code ReviewGabriel Lander03/20/2017

Actions
Actions #1

Updated by Carl Negro over 7 years ago

  • Assignee set to Gabriel Lander

When I add the checkInside parameter to appionlib/apBoxer.py, I can run makestack2 correctly. However there is still no behavior inside apBoxer.py. Gabe, do you have any uncommitted changes?

Actions #2

Updated by Gabriel Lander over 7 years ago

sorry, I totally forgot to commit this, should work now. 9b7ca555

Actions #3

Updated by Anchi Cheng over 7 years ago

  • Status changed from New to Assigned
  • Priority changed from Urgent to High
  • Target version set to Appion/Leginon 3.3
  • Affected Version changed from Appion/Leginon 3.2 to Appion/Leginon 3.3

Hi, Gabe,

Your code in apBoxer.py will still go through checkBoxInImage as is. You should put checkInside is False at the front. Saves a fraction of second, I suppose.

Actions #4

Updated by Gabriel Lander over 7 years ago

  • Assignee changed from Gabriel Lander to Anchi Cheng

good point, I swapped its position.

Actions #5

Updated by Neil Voss about 7 years ago

  • Related to Bug #4842: makestack with only boxfiles checked, produces no boxfiles added
Actions #6

Updated by William Rice about 7 years ago

  • Status changed from Assigned to Closed

Working now. Found that box files are now in a subdirectory

Actions

Also available in: Atom PDF