Bug #4940
closedMultiple targeting of same holes
0%
Description
Session 17apr28c, Tecnai F20.
Using autotargeting of exposures and verification of hl targets, seemed to get multiple instances of hl targets. Submitted 5 squares worth of targets but got 320 hl targets in queue. Expect about half that. Watching leginon it returned to the same holes again and again on the same square. Tried setting "adjust target to no ancestors" in case it was spurious corrlation, but issue remained. Manually deleted many hl targets from queue using web interface. Not sure if it is same issue the user on Krios3 had a few days ago.
Updated by Anchi Cheng about 7 years ago
Be patient when submit targets to start off. I found multiple users click submit twice when it does not seem to response the second time. I will take a look but the last few times when it happens there are indeed multiple submit.
Updated by William Rice about 7 years ago
Thanks Anchi. I suspect it may be spurious correlation. Setting the hl mover to Preset Manager and setting "Adjust Target" to No Ancestors seems to have solved the problem. Watching it navigate earlier, it seemed to jump to the same spots when moving to different holes.
Updated by Anchi Cheng over 6 years ago
Finally found why. This a behavior for more than 10 years, but not become obvious until the display is automatically refreshed when switching from another node in gui.
The code empties the list for targets in existance after a submission. If the user submit again without refreshing, it does not get this list again. Therefore the undone targets seen in the viewer get submitted again.
There is also the issue that users may click submit button more than once since the sorting of the targets can take a while and it is not clear that the targets are submitted. Solution, put a lock on gui.
Updated by Anchi Cheng over 6 years ago
- Status changed from New to In Test
- Assignee set to Laura Yen
- Target version set to Appion/Leginon 3.3
Laura,
Have you heard any user complain about this in the last month or so ? If not it means it is fixed.
Updated by Laura Yen over 6 years ago
HI Anchi,
The only time this happened for me was when I mistakenly clicked "Submit" on my on my square targets twice (because I did not see any action happen in leginon so was unsure if my targets were submitted). Solution was to wait at least 5 seconds before clicking anything twice.
Laura
Updated by Anchi Cheng over 6 years ago
- Status changed from In Test to Closed
It was also a bug that allowed the button to be clicked again before it finish saving the targets in the database. The button does not let you click until that is completed since the bug fix a month ago which is why I ask. Assume o.k.