Project

General

Profile

Actions

Bug #586

closed

Manual Acquisition camera settings does not revert correctly after manual focusing

Added by Anchi Cheng almost 14 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Start date:
05/27/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Appion/Leginon 2.0.1
Show in known bugs:
No
Workaround:

Description

The manual focus is at 1024x1. When it is finished and new image is acquired at node settings (for example 512x8), the call for acquireCorrectedImageData uses 512x8 to acquire image but would research for gain references of 1024x1. I can't see how this happens.

This can be tested with simulation.

Actions #1

Updated by Anchi Cheng almost 14 years ago

We made a patch in r14215 in myami-2.0 branch by not repeating configuration when acquire. This will cause slow-down on CM scopes, so a better fix need to be put in the trunk.

Actions #2

Updated by Neil Voss almost 14 years ago

  • Target version set to Appion/Leginon 2.1.0
  • Affected Version set to Appion/Leginon 2.0.1
Actions #3

Updated by Jim Pulokas over 13 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Jim Pulokas to Anchi Cheng
  • Show in known bugs set to No

This should eliminate the frequent problem in Manual Acquisition where sometimes the correction fails due to bad camera parameters. I completely eliminated the "repeatconfig" option in the acquire function. This may have the side effect of slowing down some things on CM scopes, but there is still the "scopeclass" option which is supposed to help with that by reducing the number of parameters retrieved from the CM when acquiring image. I have tested this fix in simulation.

Actions #4

Updated by Anchi Cheng over 13 years ago

  • Status changed from In Code Review to In Test
  • % Done changed from 0 to 100

Code is good. I will test,

Actions #5

Updated by Anchi Cheng over 13 years ago

  • Status changed from In Test to Closed

tested in simulation and on spirit.

Actions

Also available in: Atom PDF