Project

General

Profile

Actions

Bug #727

closed

incorrect angles in saxton scheme

Added by Scott Stagg almost 14 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Start date:
07/09/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Appion/Leginon 2.0.1
Show in known bugs:
No
Workaround:

Description

We discovered an error in Leginon Tomography when using equally sloped angles. The algorithm that calculates the angles does indeed make the tilt increment smaller with increasing tilts, but we found that above a certain point, the tilt increment starts increasing again at the highest tilts. I have attached a plot of the tilt increment vs. tilt angle to illustrate the problem.


Files

angles.png (24.6 KB) angles.png tilt angle vs tilt increment Scott Stagg, 07/09/2010 09:58 AM
angles2.png (33.6 KB) angles2.png Scott Stagg, 07/14/2010 11:50 AM
Actions #1

Updated by Anchi Cheng almost 14 years ago

  • Status changed from New to Assigned
  • Assignee set to Anchi Cheng
Actions #2

Updated by Anchi Cheng almost 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Jim Pulokas
  • % Done changed from 0 to 100

Implement what I think is Saxton scheme in r14465. r14466 is the gui change for it. No longer using power of 2 for determining the number of tilts per direction. Use an iterative refinement method since it is quite fast and since I can't work out the math to solve it.

Scott should to the testing.

Actions #3

Updated by Scott Stagg almost 14 years ago

That seems to have worked. The attached plot looks more like what we'd expect.

Actions #4

Updated by Anchi Cheng almost 14 years ago

Checked the original paper for the correctness of the tilts. Commit to branch 2.0 as r14652. This issue can be closed if Jim does not or does not want to find more efficient algorithm.

Actions #5

Updated by Amber Herold over 13 years ago

  • Target version set to Appion/Leginon 2.0.3
Actions #6

Updated by Sargis Dallakyan over 6 years ago

  • Status changed from In Code Review to Closed
Actions

Also available in: Atom PDF