Project

General

Profile

Actions

Bug #852

closed

auto exposure

Added by Jim Pulokas almost 14 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
08/31/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.0.2
Show in known bugs:
No
Workaround:

Description

add auto exposure node to leginon, along with new target type "meter" for selecting the auto exposure reference location.

Actions #1

Updated by Jim Pulokas almost 14 years ago

r14734: added new node with initial functionality
r14736: more changes
r14738: lot of changes regarding target types, new target type "meter", etc

Actions #2

Updated by Jim Pulokas over 13 years ago

Rick says it is not work for tilting. Here is the exception:

Exception in thread data binder handler thread:
Traceback (most recent call last):
  File "/usr/lib/python2.5/threading.py", line 486, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.5/threading.py", line 446, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib/python2.5/site-packages/leginon/databinder.py", line 131, in handleData
    method(args)
  File "/usr/lib/python2.5/site-packages/leginon/targetfilter.py", line 67, in handleQueuePublish
    newtargetlist = self.__filterTargetList(oldtargetlist,self.settings['target type'])
  File "/usr/lib/python2.5/site-packages/leginon/targetfilter.py", line 123, in __filterTargetList
    newtargetlistdata = self.submitTargets()
  File "/usr/lib/python2.5/site-packages/leginon/targetfilter.py", line 144, in submitTargets
    newtarget['list'] = newtargetlistdata
  File "/usr/lib/python2.5/site-packages/sinedon/data.py", line 498, in __setitem__
    raise RuntimeError('persistent data cannot be modified, try to create a new instance instead, or use toDict() if a dict representation will do')
RuntimeError: persistent data cannot be modified, try to create a new instance instead, or use toDict() if a dict representation will do

and also several of these, although not sure how that would be related since they seem to be more GUI related:
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/leginon/gui/wx/ImagePanelTools.py", line 535, in onNewShapeCenter
    closest_center = centers[distances.index(min(distances))]
ValueError: min() arg is an empty sequence

Actions #3

Updated by Jim Pulokas over 13 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Jim Pulokas to Anchi Cheng

Anchi, can you review r14913. I think it should fix the exception that Rick reported, but I still don't know exactly how that relates to AutoExposure not working. I'm just going to have him try it and see if the problem goes away.

Actions #4

Updated by Anchi Cheng over 13 years ago

  • Status changed from In Code Review to In Test
Actions #5

Updated by Anchi Cheng over 13 years ago

  • Status changed from In Test to Assigned
  • Assignee changed from Anchi Cheng to Jim Pulokas

I think Rick's exception message comes from Editing the raster points in "Final Raster Targeting". It need to handle meter targets properly there.

In my testing it complains that the meter targets will not be processed because it is added to the list.

Actions #6

Updated by Jim Pulokas over 13 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Jim Pulokas to Anchi Cheng

r14996 adds the options to limit the exposure time and number of attempts to change exposure time.
If either of the limits is exceded, it will give up and reset the exposure time to where it started.

Actions #7

Updated by Anchi Cheng over 13 years ago

  • Status changed from In Code Review to Closed

Code is good, Rick tested it.

Actions

Also available in: Atom PDF