Bug #946
openNeed better error checking in uploadTemplate.php
0%
Description
Comments from Pick-wei:
It works for uploading mrc file. However, it does not say that it requires the file to be mrc on the submission form and if a different file type is given, there is no check and no error report. Also, if the template already exist, it doesn't convey the message back to the user. The user has to check the log file to know that the template wasn't uploaded because there is already one in the database
Updated by Amber Herold over 13 years ago
- Assignee set to Arne Moeller
Arne, this should be a good one for you or Lauren.
Updated by Arne Moeller over 13 years ago
- Status changed from New to In Code Review
- Assignee changed from Arne Moeller to Amber Herold
Now it says which format is required.
I also changed it for upload stack and upload model where the issue was basically identical
Updated by Amber Herold over 13 years ago
- Assignee changed from Amber Herold to Arne Moeller
Arne, any chance you could investigate adding error checking for the other things Pick-wei suggested?
1. It tells the user that it needs to be Imagic now, but could you also check the file that the user enters - either check that the name ends with .mrc (ore whatever else is acceptable) or if there is a function that can be used to ensure the format is correct.
2. Check to see if the template already exists in the DB and tell user if it does. (this one might be a bit more complicated, but worth a look to see what it will take to implement)
Updated by Amber Herold over 13 years ago
- Status changed from In Code Review to Closed
- Target version changed from Appion/Leginon Future Version to Appion/Leginon 2.2.0
- Deliverable set to 2.2 Bug Reduction
Updated by Amber Herold over 13 years ago
- Status changed from Closed to In Code Review
Updated by Arne Moeller over 13 years ago
- Assignee changed from Arne Moeller to Pick-Wei Lau
I will work on the error checking for the filename
concerning the duplicate template name - then name for the template is generated including a time stamp and I do not see many occasions when this actually can cause a duplicated filename and thus might be a problem - I never encountered any problems with that and do not think it is worth spending time on that.
Since Pick Wei submitted the bug he probably has some examples when this actually happend.
So I bounce this bug back to him