Bug #959
closedqueue timeout option not working with grid atlas
0%
Description
reported by Rick Fetter: if queue timeout is toggled in Grid node, the shutdown procedure is called after 20 seconds even if atlas is still being acquired. this is because grid atlas acquisition is not even using queuing, but the loop that checks for queue timeout is running all the time.
Updated by Jim Pulokas over 13 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Jim Pulokas to Anchi Cheng
Important: this requires new applications to be imported into DB due to change in event class. As soon as code review and maybe testing is done, we need to do this at NRAMM for betaleginon to work. Also, people need to be instructed to use the latest 2.2 versions of application.
r14910 changes MosaicTargetMaker to it sends a queue to the acquisition node instead of target list.
It should allow toggle queue timeout option for atlas creation.
I have tested this with MSI-Section3step and SimTEM, but no others.
Updated by Anchi Cheng over 13 years ago
- Status changed from In Code Review to In Test
- Priority changed from Normal to Urgent
- Target version set to Appion/Leginon 2.2.0
- Affected Version changed from Appion/Leginon 2.0.2 to Appion/Leginon 2.1.0
Code is fine. I will test it tonight on my Mac and import them on cronus4 because betaleginon is pointing to the trunk.
Updated by Anchi Cheng over 13 years ago
- Status changed from In Test to Assigned
- Assignee changed from Anchi Cheng to Jim Pulokas
- Priority changed from Urgent to Normal
r14919 reverts targetmaker.py and targetwatcher.py back because if I submit two targets from atlas with Hole_Targeting in queuing mode, only one target is processed. The second one is not marked done in the atlas but can not be used to acquire Square image any more. Same problem in MSI-Section3Step since Tissue_Centering is in queuing mode.
Updated by Jim Pulokas over 13 years ago
It is testing ok on my sandbox, which is currently at r14916.
This is what I am doing:
- MSI-Section3step
- Queue in Tissue Centering
- pick three targets on atlas
- pick one target on each of the three in Tissue Centering
- pick two targets in final raster for each
It gets through all the targets and then I refresh the atlas and the targets show up as done.
There must be some settings that I am not doing the same as you.
Updated by Anchi Cheng over 13 years ago
I tried it again. It is fine if the targets are from different tiles of the atlas.
However, it only does one if the two targets you picked from the atlas are on the same tile.
Updated by Anchi Cheng over 13 years ago
It is getting wierd. Very irregular. I picked two targets on an existing atlas each time. Some of them processed none, some processes one and some processed both.
Updated by Jim Pulokas over 13 years ago
In r14931 I reverted all the other applications that were changed to use a Queue instead of target list, so it is as if r14910 never happened. Now working on a completely different approach. Instead of using Queue timeout, which is too much of a mess, I will have a dedicated option for atlas creation only that puts it in "park" when atlas is done.
Updated by Jim Pulokas over 13 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Jim Pulokas to Anchi Cheng
Added "park" option in r14932. This advanced setting will cause column valves to close and stage to reset to 0,0,0,0 after every target list is completed.
Updated by Anchi Cheng over 13 years ago
- Status changed from In Code Review to Closed
code reviewed by me, tested by Rick Fetter