Project

General

Profile

Actions
Copy link

Bug #991

closed

remove recursive session search in getSessions

Added by Anchi Cheng over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
Appion/Leginon 2.2.0
Start date:
11/02/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Appion/Leginon 2.0.2
Show in known bugs:
No
Workaround:

Description

Can't understand why getSessions function in myamiweb/inc/leginon.inc need recursive getSession without projectId to union with the one with, so I am going to merge that with the other.

Actions
Copy link
 #1

Updated by Anchi Cheng over 13 years ago

  • Tracker changed from Task to Bug
  • Assignee changed from Anchi Cheng to Amber Herold
  • % Done changed from 0 to 100
  • Affected Version set to Appion/Leginon 2.0.2
  • Show in known bugs set to No

r14981 removed the projectId recursive union. Unfortunately it needs several different cases to keep it from joining all potential tables together. Hope this is better and more readable.

testing:
Check the sessions displayed in session selectors in any image viewer under the following cases:
1. as administrator user and seeing all projects.
2. as administrator user and select one project
3. as user in users or guests group and seeing all projects
4. as user in users or guests group and select one project

Case 4 might be slightly faster by removing the recursive search.

Actions
Copy link
 #2

Updated by Amber Herold over 13 years ago

  • Status changed from Assigned to In Code Review
Actions
Copy link
 #3

Updated by Amber Herold over 13 years ago

  • Target version set to Appion/Leginon 2.2.0
Actions
Copy link
 #4

Updated by Amber Herold over 13 years ago

  • Deliverable set to 2.2 Bug Reduction
Actions
Copy link
 #5

Updated by Amber Herold over 13 years ago

  • Status changed from In Code Review to Closed
Actions
Copy link

Also available in: Atom PDF