Bug #1706
closedtest-image in Dogpicker not working
0%
Updated by Amber Herold about 12 years ago
- Status changed from New to Assigned
- Priority changed from Normal to High
- Target version set to Appion/Leginon 2.2.0
Updated by Amber Herold about 12 years ago
The test single image feature is not working because there is a race condition.
If you run the command, it may not complete before the web page tries to report results. It helps if you set reading
the stream after ssh2_exec to be blocking, but blocking adds a good chance of hanging. There is also a sleep ofter the execute command (double yuckiness) to allow commands to complete before moving on, and I don't want to make it wait longer just for the test feature. Ideally, we should get rid of the sleep and try a different method of waiting for the command to execute. So far my reasearch finds silly solutions like writing a file at the end or adding echo "[end]" after the command and looking for [end] in the output stream. Crazy.
Since we are so close to a release, I will leave the sleep and wait a while for the test results to show up before assuming the test didn't run properly.
Updated by Amber Herold about 12 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Amber Herold to Anchi Cheng
Anchi, please take a look at this, it is a bit of a mess, so probably most important that you understand what I'm doing so that we can reasonably return to it in the future if needed.
There is something going on that I have not been able to determine... seems that the function to check if a file exists sometimes returns false even when the file exists, and will continue returning false for over 20 seconds before getting it right. Because of this, every once in a while, we will think there was an error because it looks like the file does not existr even though it does. In this case, I instruct the user to try refreshing the page, which will always load the image correctly.
Please assign to Arne to test.
Updated by Anchi Cheng about 12 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Anchi Cheng to Arne Moeller
Code is as good as it can be in this situation.
Updated by Anchi Cheng almost 12 years ago
- Status changed from In Test to Assigned
- Assignee changed from Arne Moeller to Amber Herold
$max_mod_time is not used but in its place 35 is hard-coded when it is needed.
35 seconad is not good on some computers. May need configuration by the installer.
Please assign back to Arne to test.
Updated by Anchi Cheng almost 12 years ago
r16697 added clearstatcache before the first file_exists check so that JustShowCommand won't be stuck in "file not found" when user refreshs the page.
r16698 merge the same change to 2.2 branch
Updated by Amber Herold almost 12 years ago
- Target version changed from Appion/Leginon 2.2.0 to Appion/Leginon 2.2.1
Will take care of hard-coded 35 value in next version.
Updated by Amber Herold about 10 years ago
- Status changed from Assigned to Closed
addressed in r18147