Project

General

Profile

Actions

Bug #3553

closed

Stop using SPIDER for highpass filter and use python-based code

Added by Neil Voss over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
09/14/2015
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.2
Show in known bugs:
No
Workaround:

Description

Stop using SPIDER for highpass filter and use python-based code


Related issues 1 (0 open1 closed)

Related to Appion - Feature #3970: Simplify the particle picking interfaceWon't Fix or Won't Do 02/19/2016

Actions
Actions #1

Updated by Neil Voss over 8 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Neil Voss to Anchi Cheng

Note: we are using highPassFilter2() not highPassFilter()

Actions #2

Updated by Dmitry Lyumkis over 8 years ago

  • Assignee changed from Anchi Cheng to Neil Voss

current bug in templateCorrelator:

dlyumkis@bpho-bladerunner-1 jpgs] templateCorrelator.py --runname=tmplrun5_220heter --rundir=/data2/log-l/appion/15sep15a/extract/tmplrun5_220heter --projectid=2 --session=15sep15a --no-rejects --no-wait --no-commit --no-continue --mrclist=15sep15a_00022sq_00036hl_00002ed-a.mrc --overlapmult=1.25 --peaktype=centerofmass --maxpeaks=200 --thresh=0.48 --invert --median=2 --lowpass=22 --planereg --bin=4 --diam=220 --pixlimit=4.0 --template-list=57,55,53,51,49,47,45,43,41,39,37 --range-list=0,10,20x0,10,20x0,10,20x0,10,20x0,10,20x0,10,20x0,10,20x0,10,20x0,10,20x0,10,20x0,10,20 --thread-findem --use-mirrors 
 ... Time stamp: 15sep16l55
 ... Function name: templateCorrelator
 ... Appion directory: /data2/log-l/progs/myami/appion
!!! WARNING: There is more than one appion directory in your PYTHONPATH
['/usr/local/appion/EMAN2/bin', '/data2/log-l/progs/myami/appion', '/usr/local/appion/EMAN2/lib']
 ... Using split database
Connected to database: 'ap2'
!!! WARNING: Not committing data to database
 ... Found 40 processors on this machine
 ... Found project id=2 for session 15sep15a in 8.28 msec
 ... Run directory: /data2/log-l/appion/15sep15a/extract/tmplrun5_220heter
!!! WARNING: directory '/data2/log-l/appion/15sep15a/extract/tmplrun5_220heter' already exists.
 ... Writing function log to: templateCorrelator.log
 ... Uploading ScriptData....
 ... Found 40 processors on this machine
 ... Running Appion version 'trunk-r19170M'
 ... Creating new done dictionary: templateCorrelator.donedict
Querying database for 1 specific images ... 
 ... Looking up session, 15sep15a
 ... Found 1 images in 5.35 msec
 ... Remove processed images
 ... finished skipping in 16.13 msec
 ... Process images old to new
 ... getting templates
 ... getting template: /data2/log-l/appion/15sep15a/templates/template15sep16d14/IKK2_tetramer_box_64_apix_3.93_image_43-15sep16k36.mrc
 ... reading MRC: origTemplate1.mrc size:(64, 64) dtype:float32
 ... rescaling template 1: 3.93->1.31
 ... scaling template by a factor of 3.0
Traceback (most recent call last):
  File "/data2/log-l/progs/myami/appion/bin/templateCorrelator.py", line 8, in <module>
    imgLoop.run()
  File "/data2/log-l/progs/myami/appion/appionlib/appionLoop2.py", line 63, in run
    self.preLoopFunctions()
  File "/data2/log-l/progs/myami/appion/appionlib/apTemplateCorrelator.py", line 139, in preLoopFunctions
    apTemplate.getTemplates(self.params)
  File "/data2/log-l/progs/myami/appion/appionlib/apTemplate.py", line 73, in getTemplates
    templatearray = apImage.preProcessImage(templatearray, params=params, highpass=0, planeReg=False, invert=False)
  File "/data2/log-l/progs/myami/appion/appionlib/apImage/imagefilter.py", line 121, in preProcessImage
    result = _processImage(imgarray, bin, apix, lowpass, highpass, planeReg, median, invert, pixlimit, msg)
  File "/data2/log-l/progs/myami/appion/appionlib/apImage/imagefilter.py", line 43, in _processImage
    simgarray = highPassFilter2(simgarray, highpass, apix)
  File "/data2/log-l/progs/myami/appion/appionlib/apImage/imagefilter.py", line 549, in highPassFilter2
    filter = tanhFilter(hpFilterSize, data.shape)
  File "/data2/log-l/progs/myami/appion/appionlib/apImage/imagefilter.py", line 572, in tanhFilter
    filter = numpy.tanh(radial/fuzzyEdge - 1.01*(max(shape))/float(pixelradius)/fuzzyEdge)/2.0 + 0.5
ZeroDivisionError: float division
Actions #3

Updated by Neil Voss over 8 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Neil Voss to Dmitry Lyumkis

Well, one of these values must be zero:

radial, fuzzyEdge, max(shape), pixelradius

my guess is pixelradius

Actions #4

Updated by Dmitry Lyumkis over 8 years ago

  • Assignee changed from Dmitry Lyumkis to Neil Voss

this looks ok now, I'm actually not sure what exactly the issue was, I will have to backtrack to see what exactly was done ...

Actions #5

Updated by Neil Voss over 8 years ago

  • Related to Feature #3970: Simplify the particle picking interface added
Actions #6

Updated by Neil Voss over 8 years ago

  • Status changed from In Test to Closed
  • Assignee deleted (Neil Voss)

I am going a different direction with this, see #3970 in future.

Actions

Also available in: Atom PDF