Bug #65
closed
Users should not be allowed pick particles outside of the image.
Added by Neil Voss over 14 years ago.
Updated about 14 years ago.
Description
In the TiltPicker, it is possible to pick particles outside of the image. Normally, this is not a problem except that you cannot easily remove these erroneous picks.
I propose that the picks either (1) be rejected in the ImagePanel onClick function or (2) be cleared when the onApply button is pushed.
This is not a general feature for the ImagePanel, because in Leginon it is desirable to pick outside the image when using the navigator.
But this could also be applied to the ManualPicker.
source:trunk/appion/bin/manualpicker.py
source:trunk/appion/bin/ApTiltPicker.py
- Status changed from Assigned to In Code Review
- Assignee changed from Neil Voss to Amber Herold
- % Done changed from 0 to 100
- Estimated time set to 0.10 h
This bug is fixed for ApTiltPicker (r13037) and manualpicker (r13038).
Tested in the GUI for both programs.
Why do you check for x and y > 2 rather than 0 or 5 or something else?
- Assignee changed from Amber Herold to Neil Voss
- Assignee changed from Neil Voss to Amber Herold
you are picking the center of the particle, so pixel zero is too close to the edge. I thought 5 pixels would be too much, so I choose 2. The most mathematically pleasing choice would be 0, but the user cannot tell the difference between 0 and 2 in the GUI.
- Project changed from Appion to TiltPicker
- Category deleted (
3)
- Target version set to TiltPicker v2.0
- Status changed from In Code Review to Closed
Also available in: Atom
PDF