Project

General

Profile

Actions

Bug #885

closed

When using manualpicker.py to edit labeled old pick, the label option must be on and contains the old labels.

Added by Anchi Cheng over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
Start date:
09/20/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

Need to prevent users from missing the existing labels. A left-over bug from adding feature #230

Actions #1

Updated by Anchi Cheng over 13 years ago

  • Status changed from New to In Code Review
  • Assignee set to Eric Hou
  • Target version set to Appion/Leginon 2.1.0
  • % Done changed from 0 to 100
  • Affected Version changed from Appion/Leginon 2.0.2 to Appion/Leginon 2.1.0

Include labels from editing picks and add them to the label list which are not allowed to be removed. These labels are merged with the user chosen ones. Also added code to prevent user from using existing un-labeled pick run name as a label, since the python code will do this automatically. r14809

In addition, replace the variable name for the particle pick runs to be edited from pickrun to editrun so that it is more clear what it is for. In addition, clean up testimage related code since it is not used and would never be used in the case of manual picking. r14809

Testing:
1. go to runManualPicker.php page for a session that has an existing labeled pick run.
2. choose the labeled run for "Edit particle pick". The labels exists for the run will show up in the page. If a different run is chosen, the label will be updated, too. If a label comes from an editing pick run, the delete label button does not show.
3. The command generated from the php page should include these labels
4. go to runManualPicker.php page for a session that has an existing un-labeled pick run.
5. choose the unlabeled run for "Edit particle pick".
6. add a label of the same runname as the "Edit particle pick" run. The page should reject it and return an error message.

Anyone can test.

Actions #2

Updated by Eric Hou over 13 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Eric Hou to Amber Herold
Actions #3

Updated by Amber Herold over 13 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF