Project

General

Profile

Actions

Bug #957

closed

Can't choose output directory.

Added by Christopher Irving over 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
High
Assignee:
Amber Herold
Category:
-
Target version:
Start date:
10/20/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.0.2
Show in known bugs:
No
Workaround:

Description

On many of the appion processing pages users are unable to choose their output directory. This can lead to some obvious problems. All myami code which generates data needs to allow the user to select the output directory.


Related issues 1 (0 open1 closed)

Related to Appion - Bug #30: Cannot choose a output directory for all pagesDuplicateLauren Fisher01/15/2010

Actions
Actions #1

Updated by Eric Hou over 13 years ago

  • Target version changed from Appion/Leginon 2.1.0 to Appion/Leginon 2.2.0
Actions #2

Updated by Eric Hou over 13 years ago

  • Priority changed from Normal to High
Actions #3

Updated by Lauren Fisher over 13 years ago

I think the only problem is there is a flag in the php code that disables the input box, which prevents user input. For example in uploadstack.php the code for the Output directory box is:

echo docpop('outdir','<b>Output directory:</b>');
echo "<br/>\n";
echo "<input type='text' name='disoutdir' value='$outdir' size='40' disabled/>\n";
echo "<input type='hidden' name='outdir' value='$outdir'/>\n";

When I remove the "disabled" flag in the code output directory box becomes active. Is there any reason why the programmer initially wanted this feature disabled? What are the problems if the user cannot control the output directory? I think I can handle this bug if you want to reassign it to me, Eric.

Actions #4

Updated by Eric Hou over 13 years ago

  • Assignee changed from Eric Hou to Lauren Fisher

Yes, that is only thing you need to do. Neil was showing this in the Appion development meeting couple month ago.
You have searched all the files under processing folder using "Output Directory"

I guess most of the files already convert to be able to edit the output directory.

Since we are letting user to input any output directory location, we might need to do a validation in the feature.

Thanks.

Eric

Actions #5

Updated by Amber Herold over 13 years ago

  • Deliverable set to 2.2 Bug Reduction
Actions #6

Updated by Lauren Fisher over 13 years ago

  • Status changed from New to In Code Review
  • Assignee changed from Lauren Fisher to Eric Hou
Actions #7

Updated by Lauren Fisher over 13 years ago

Make sure output directories are all active and able to be edited by user. PHP code review on:
uploadTemplateStack.php - r15097, r15110
jumpSubStack.php - r15098, r15104
uploadstack.php - r15099, r15105
uploadtemplate.php - r15100, r15107
uploadimage.php - r15101, r15109
alignSubStack.php - r15111
applyJunkCutoff.php - r15147
coranSubStack.php - r15148
postproc.php - r15149
sortJunk.php - r15150
runClusterCoran.php - r15151, r15200
uploadrecon.php, uploadXmippRecon.php - r15183
uploadFrealign.php =- r15185

Actions #8

Updated by Lauren Fisher over 13 years ago

r15184 reset uploadimage.php to the original layout which has no output directory input. Anchi pointed out that if you are uploading images to a new session there will be no default output directory and the user would have to input one from scratch. This is dangerous. In addition, if you are uploading more images to a session they must all go to the same location. Giving the user the ability to input the directory opens up a lot of room for error and will most certainly cause problems down the road if they are uploading images in the same session to different directories. If there are any other tools that have been changed that will present problems such as this one, let me know and I will change them back. Also, I am refraining from editing the tomography tools at this point because I have never used them and do not know how they work. If someone else wants to take these on, please do so.

Actions #9

Updated by Anchi Cheng over 13 years ago

runClusterCoran.php and other clustering routines may not be a good candidate for editable outdir because it uses the feature analysis runname and does not record its own path in the database. However, I see that apClusterStackData does have path taken from rundir

Neil, would there be a problem if the feature analysis and clustering use different rundir?

Actions #10

Updated by Neil Voss over 13 years ago

Clustering needs to be run in the same directory as feature analysis, they are linked together.

Actions #11

Updated by Eric Hou over 13 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Eric Hou to Amber Herold
Actions #12

Updated by Lauren Fisher over 13 years ago

r15200 disabled the output directory in runClusterCoran.php and added a note explaining to the user why it can't be edited. This is linked to bug #1097 as well.

Actions #13

Updated by Amber Herold about 13 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF