Project

General

Profile

Actions

Bug #1790

closed

get_magnification on existing TEM corrupts the database

Added by Anchi Cheng over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
-
Start date:
05/09/2012
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.2.0 (trunk)
Show in known bugs:
No
Workaround:

Description

It adds a new TEM instrument without Cs value. Most likely the insertion did not query database first.

Actions #1

Updated by Anchi Cheng over 12 years ago

  • Status changed from Assigned to In Code Review

fixed with r16600 and r16602. Tested on new database already. This requires update of the installation on the microscope.

Actions #2

Updated by Jim Pulokas over 12 years ago

Anchi,
I made a different approach to your fix in r16620, then realized it was a bad idea and reverted back in r16622. My confusion is whether this nested insert will ever create a new InstrumentData. If that is the case, then my alternate approach would not work, since it queries InstrumentData before the mag list is inserted. The advantage of my approach is that it will continue to work even if we add new attributes just like we added "cs".

Actions #3

Updated by Jim Pulokas over 12 years ago

  • Status changed from In Code Review to Closed

works good enough, will open a new issue for some future enhancements.

Actions

Also available in: Atom PDF