Project

General

Profile

Actions
Copy link

Bug #2222

closed

image adjust stays at manual settings when switch back to auto

Added by Anchi Cheng almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
myamiweb
Target version:
Appion - Appion/Leginon 3.0.0
Start date:
01/27/2013
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

This has been like this for a long time. The values that defines the viewer parameter does not get updated when it is switched back.

Actions
Copy link
 #1

Updated by Anchi Cheng almost 12 years ago

  • Status changed from Assigned to In Code Review
  • Assignee set to Amber Herold
  • Target version set to Appion/Leginon 3.0.0

r17357 fixed this
jsloadfromjpg is the variable changed when the pop-up is switched to auto.

Testing (anyone)

  1. Go to any myamiweb image viewer and open adjust.php
  2. Change the mode from auto to manual.
  3. Change Image Contrast to something obvious
  4. Switch back to auto adjust.
Actions
Copy link
 #2

Updated by Amber Herold almost 12 years ago

  • Assignee changed from Amber Herold to Anchi Cheng

Reviewed,
Anchi, not sure why the default value: 

$currentfftbin='a';
is being changed to "b"?

Tested as well, can close out now.

Actions
Copy link
 #3

Updated by Anchi Cheng almost 12 years ago

  • Status changed from In Code Review to Closed
  • Assignee changed from Anchi Cheng to Amber Herold

I changed the default to corresponds better to what imcache creates as jpg, although it may still be debatable which we should keep as default. "a" option does not have any effect on the viewer image since they are small, but a smaller bin in that mode will allow users to see more details in the pop-up map when they click on the image. "b" option binning is not ideal at the moment as I had to use resampling on the resulting power spectrum and it looks pixelated. It however will allow a zoom effect in the viewer image, useful when user only interested in the lower resolution part. Since the cache does no binning in real space for any image smaller than 4096, and then bin in the power spectrum to 1024 to reduce the image size, neither option applies to it properly.

Actions
Copy link

Also available in: Atom PDF