Project

General

Profile

Actions

Feature #287

closed

Move the default CS variable from Processing_config to the Leginon Database instrument config

Added by Amber Herold over 14 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Amber Herold
Category:
-
Start date:
03/31/2010
Due date:
% Done:

0%

Estimated time:
Deliverable:

Description

There is a poorly commented default CS variable in the processing_config file that needs to be moved...or at least better commented.
Jim and Anchi know about this.


Related issues 3 (0 open3 closed)

Blocked by Leginon - Feature #1305: better display of instrument.py getData function exceptionClosedJim Pulokas05/18/2011

Actions
Blocked by Leginon - Feature #1308: cs input from instruments,cfg to database InstrumentDataClosedAnchi Cheng05/23/2011

Actions
Blocked by Appion - Feature #1307: include cs value for appionTEM when uploading imageClosedAmber Herold05/19/2011

Actions
Actions #1

Updated by Amber Herold over 14 years ago

  • Project changed from Appion to Leginon
Actions #2

Updated by Anchi Cheng over 14 years ago

I also need C2 aperture demagnification factor (5.2 in microprobe mode, 40 in nanoprobe) for Tecnai 200 series, and distance between eucentric point to virtual image of C2 aperture (3.4 mm in microprobe mode, 85 um in nanoprobe) for Tecnai 200 series stored as instrument parameters for beamtilt correction. I am hard coding it now, BAD IDEA!

Actions #3

Updated by Neil Voss over 14 years ago

  • Target version set to Appion/Leginon 2.1.0
Actions #4

Updated by Eric Hou about 14 years ago

  • Target version changed from Appion/Leginon 2.1.0 to Appion/Leginon Future Version

This is a broader issue of how to define instruments for both leginon and appion...need to use a common table

Actions #5

Updated by Anchi Cheng over 13 years ago

  • Status changed from New to Assigned
  • Assignee changed from Jim Pulokas to Anchi Cheng
  • Priority changed from Normal to Urgent
  • Target version changed from Appion/Leginon Future Version to Appion/Leginon 2.2.0
Actions #6

Updated by Anchi Cheng over 13 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Amber Herold

The assumption we will make is that all images in the session have the same Cs value. Don't know if we might merge atomic resolution data from different TEM in the future. This will do for now since programs such as frealign only has one cs input for the whole dataset.

r15653 made the change in the appion. I have not done makestack2.py and makehelicalstack.py change since they can still get cs from ctf runs. Want to give it a bit of time after other codes are sure to work.
I put the call of getCsValueFromSession in checkConflicts function to be consistent although it is not really checking conflict but to set params. There are other set params in checkConflicts, so I've leave it that way, too.

r15654 made the change in myamiweb/processing. Cs values are no longer an input.

r15655 is the database schema update required to use existing database and microscopes.

See #1307 about problem that would cause if older appion upload is done or new microscope is added using current code after this revision.

I will need to test the Leginon side of cs value input on the scope and upgrade them at the scope all at the same day so that they are synced before other users start to get the new revision next day.

Testing:

Run each of the script I've changed. It should not crash and cs value in each ctf estimation/correction run and freealign job should come out right.

Amber, please code review these first and have someone test them. I will create a subtask for the Leginon new microscope part.

Actions #7

Updated by Amber Herold over 13 years ago

  • Assignee changed from Amber Herold to Anchi Cheng

Anchi,
looks good.

One minor change I would make is in the schema update, rather than raising an exception if the user does not choose to continue with the script, I would display a message that the script is exiting and exit.

if not answer.lower().startswith('y'):
  raise RuntimeError

An unhandled exception might make it look like something terribly bad happened rather than the normal course of execution.

Actions #8

Updated by Anchi Cheng over 13 years ago

  • Subject changed from Move the default CS variable feom Processing_config to the Leginon Database instrument config to Move the default CS variable from Processing_config to the Leginon Database instrument config
  • Assignee changed from Anchi Cheng to Amber Herold

r15659 uses sys.exit() for rawinput of no.

Actions #9

Updated by Amber Herold over 13 years ago

  • Status changed from In Code Review to In Test

Great.

Actions #10

Updated by Amber Herold over 10 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF