Project

General

Profile

Actions
Copy link

Bug #4882

closed

Leginon setup.py version error

Added by Anchi Cheng over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Appion - Appion/Leginon 3.3
Start date:
04/03/2017
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.3
Show in known bugs:
No
Workaround:

Description

running install_egg_info
Traceback (most recent call last):
  File "setup.py", line 31, in <module>
    scripts=['install-leginon.py', 'start-leginon.py'],
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/command/install.py", line 575, in run
    self.run_command(cmd_name)
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/dist.py", line 971, in run_command
    cmd_obj.ensure_finalized()
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/cmd.py", line 109, in ensure_finalized
    self.finalize_options()
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/command/install_egg_info.py", line 26, in finalize_options
    to_filename(safe_version(self.distribution.get_version())),
  File "/opt/applications/python/2.7.13/gnu/lib/python2.7/distutils/command/install_egg_info.py", line 69, in safe_version
    version = version.replace(' ','.')
AttributeError: 'int' object has no attribute 'replace'
Actions
Copy link
 #1

Updated by Anchi Cheng over 7 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Neil Voss

python setup version needs to be string. I changed it this way. Please check.

Actions
Copy link
 #2

Updated by Neil Voss over 7 years ago

  • Status changed from In Code Review to Closed
  • Assignee deleted (Neil Voss)

Hi Anchi, this is fine. I wanted to move away from a string because it is hard to do comparisons on strings, e.g., is version 3.2 > 3.1, but we could stick to string globally as well.

Actions
Copy link
 #3

Updated by Anchi Cheng over 7 years ago

Integer return of the getVersion function is fine.

Actions
Copy link

Also available in: Atom PDF