Project

General

Profile

Actions

Bug #639

closed

revertsettings.php warms about missing argument

Added by Anchi Cheng over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Eric Hou
Category:
-
Start date:
06/07/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Show in known bugs:
Workaround:

Description

need to clean up the code

Actions #1

Updated by Anchi Cheng over 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Anchi Cheng to Amber Herold
  • Priority changed from Normal to Urgent

fixed both warning message about missing argument and missing first array in array_diff_keys. The former is fixed with a default empty string. The function might not need the argument any more but I will leave it as is until I work on admin_settings.php later.

The latter came from our dbemdata not having BeamTiltImagerSettingsData defined for administrator user.  Catch the exception and display warning messages.  This makes me realize the upgrading users need a way to revert to original default, a feature lost in this version. so I added it back in.

r14302 in trunk
merged this and #640 changes to commit r14304 in the branch

Eric can test.

Testing:
1. Use an older test dbemdata (before Jun 7) or Scott's upgraded database.
2. Go to myamiweb/revertsettings.php
3. Choose a test user and revert his/her settings to default
4. You should get some print out of which settings tables are missing, not php error.
5. Click on Revert Settings icon on the left to reset the page.
6. Click on "Revert to Original"
7. It should say that it is successful.
8. repeat 2 and 3. This time there should not be missing administrator tables because you have set it to the installation original in step 5 to 7.
Actions #2

Updated by Anchi Cheng over 14 years ago

  • % Done changed from 0 to 100
Actions #3

Updated by Amber Herold over 14 years ago

Modified gui text in r14305 for trunk and r14306 for 2.0 Branch.

Actions #4

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Amber Herold to Eric Hou
Actions #5

Updated by Anchi Cheng over 14 years ago

apply legionDBSchema before reverting to original r14313 in trunk, r14314 in branch

Actions #6

Updated by Eric Hou over 14 years ago

  • Status changed from In Test to Closed

tested are good.

Eric

Actions

Also available in: Atom PDF