Project

General

Profile

Actions

Bug #718

closed

leginon.inc problems

Added by Jim Pulokas over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Image Viewer
Start date:
07/06/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Appion/Leginon 2.0.1
Show in known bugs:
No
Workaround:

Description

email from Marco Oster:

find attached a small patch for myamiweb or more specific the file
inc/leginon.inc. I had problems converting my old database to the new
database scheme, and tried to set it up differently. Maybe an explicit
hint to the initial setup routines in the manual is helpful :)

I wanted to test the image viewer, but with the initial database from
this setup routine, no picture showed up. I tracked it down to
leginon.inc's getFilename(..) routine which referenced a table in it's
sql query which didn't exist yet (PresetData). With this query
failing, no IDs were filled into the list and no pictures were loaded.

Since the query without the left join to this PresetData table showed
a usable result, I implemented a condition to check for the existence
of that table first.

I think there was also a previous error in the routine,
($has_imageStatusData vs if($has_ImageStatus)) which I sorted out,
too. But I'm not that into php, maybe I was wrong with that.

Actions #1

Updated by Jim Pulokas over 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Jim Pulokas to Anchi Cheng

applied Marco's patch in r14444. If this tests out ok, it can probably merge into stable branch too.

Actions #2

Updated by Anchi Cheng over 14 years ago

  • Status changed from In Code Review to Closed
  • % Done changed from 0 to 100

tested and apply changes to branch 2.0 as r14538

Actions

Also available in: Atom PDF