Project

General

Profile

Actions
Copy link

Bug #8111

closed

Align_ZLP does not send scope to check preset during testing

Added by Laura Yen about 5 years ago. Updated about 4 years ago.

Status:
Won't Fix or Won't Do
Priority:
Normal
Assignee:
Laura Yen
Category:
-
Target version:
Appion/Leginon 3.6
Start date:
10/07/2019
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.4
Show in known bugs:
No
Workaround:

Description

Align_ZLP is no longer sending the scope to the defined preset when doing automatic ZLP check. For example, if you are currently in the square preset, and the align_ZLP node gets triggered, the node does not send the scope to the fan preset and you get an error in the align_ZLP node that says "energy filter not enabled". Align_ZLP node used to send scope to fan preset but now it does not.

Actions
Copy link
 #1

Updated by Anchi Cheng about 5 years ago

The play tool in AlignZLP is just a test for the workflow. It has never been able to send preset. Triggering AlignZLP through the request sent by another node, typically Exposure Node.

Actions
Copy link
 #2

Updated by Anchi Cheng about 5 years ago

  • Assignee set to Laura Yen

Laura, when you say trigger, you are talking about clicking play tool in AlignZLP, am I right ?

Actions
Copy link
 #3

Updated by Anchi Cheng about 5 years ago

  • Subject changed from Align_ZLP does not send scope to defined preset to Align_ZLP does not send scope to check preset during testing
  • Status changed from New to Assigned
  • Assignee changed from Laura Yen to Anchi Cheng

After discussion, we decide that the new behavior is caused by a change in standard protocol that uses 0 as threshold for checking if slit has drifted. The settings make it not to check and thus not to send that preset.

I will change the code to specifically allow using check preset instead of current preset for AlignZLP node. However, be advised that all reference nodes such as dose measurement or phase plate conditioning requires the right preset to be sent before testing.

Actions
Copy link
 #4

Updated by Anchi Cheng almost 5 years ago

  • Status changed from Assigned to Closed
  • Target version set to Appion/Leginon 3.5

code changed and works

Actions
Copy link
 #5

Updated by Anchi Cheng about 4 years ago

  • Status changed from Closed to Won't Fix or Won't Do
  • Assignee changed from Anchi Cheng to Laura Yen
  • Target version changed from Appion/Leginon 3.5 to Appion/Leginon 3.6

I had to revert this feature because this causes confusion on which preset it will use in the actual call from other nodes that send request preset and it creates a conflict with feature Issue #9489 that must uses proper request preset.

Actions
Copy link

Also available in: Atom PDF