Project

General

Profile

Actions

Feature #13578

open

redux: configurable archive (webimg) loader

Added by cesar mena over 1 year ago. Updated over 1 year ago.

Status:
Assigned
Priority:
Normal
Assignee:
Category:
-
Start date:
10/03/2022
Due date:
% Done:

0%

Estimated time:

Description

When an .mrc is not found by redux an attempt is made to load a corresponding jpg from the webimg archive.

This commit adds an interface to make this functionality configurable. The configuration is optional and backwards compatible.

Configuration options are:

- legacy (default if nothing specified)
- memc
- nccat
- noop
- file: should point to a .py which exports a `path` function with the signature: path(str: mrc_path) -> str which returns an abs path of a jpg version of the passed mrc.


Files

Actions #1

Updated by Anchi Cheng over 1 year ago

  • Status changed from New to Assigned
  • Assignee set to cesar mena
  • Target version set to Appion/Leginon Future Version

Cesar, what goes into the repository should not include specific site information like /h1/, /h/,/gpfs/, /memc/. Can I suggest that you make a webimg.py.template that does not include site-specific information and push that to the repository instead of what you have ? You can also add the needed configuration in a new section in redux.cfg.template and make webimg.py reads that from the non-deposited redux.cfg

Actions #2

Updated by cesar mena over 1 year ago

Sure thing.
-cm

From: <mailto:>
Sent: Tuesday, October 25, 2022 11:47
To: Bridget Carragher<mailto:>; Ed Eng<mailto:>; <mailto:>; Cesar Mena<mailto:>
Subject: [Appion - Feature #13578] (Assigned) redux: configurable archive (webimg) loader

Issue #13578<https://emg.nysbc.org/issues/13578#change-51262> has been updated by Anchi Cheng.

  • Status changed from New to Assigned
  • Assignee set to cesar mena
  • Target version set to Appion/Leginon Future Version

Cesar, what goes into the repository should not include specific site information like /h1/, /h/,/gpfs/, /memc/. Can I suggest that you make a webimg.py.template that does not include site-specific information and push that to the repository instead of what you have ? You can also add the needed configuration in a new section in redux.cfg.template and make webimg.py reads that from the non-deposited redux.cfg

Feature #13578: redux: configurable archive (webimg) loader<https://emg.nysbc.org/issues/13578#change-51262>

  • Author: cesar mena
  • Status: Assigned
  • Priority: Normal
  • Assignee: cesar mena
  • Category:
  • Target version: Appion/Leginon Future Version

When an .mrc is not found by redux an attempt is made to load a corresponding jpg from the webimg archive.

This commit adds an interface to make this functionality configurable. The configuration is optional and backwards compatible.

Configuration options are:

- legacy (default if nothing specified)
- memc
- nccat
- noop
- file: should point to a .py which exports a `path` function with the signature: path(str: mrc_path) -> str which returns an abs path of a jpg version of the passed mrc.

You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://emg.nysbc.org/my/account

Actions #3

Updated by cesar mena over 1 year ago

  • Status changed from Assigned to In Code Review
Actions #4

Updated by Anchi Cheng over 1 year ago

  • Status changed from In Code Review to Assigned
  • Assignee changed from cesar mena to Anchi Cheng

tested on my sandbox. Ran into one problem:

webimg.py import reduxconfig as local import which caused my reduxd that not launched from redux directory fails. Please use

import redux.reduxconifg

or

from redux import reduxconifg

Actions #5

Updated by cesar mena over 1 year ago

switched to absolute import.

Actions

Also available in: Atom PDF