Feature #1550
closed
Revert settings to that of a specific session
Added by Anchi Cheng over 12 years ago.
Updated about 10 years ago.
Description
In case that good settings are changed in a newer session but the user can't remember what has been altered.
r16331 added query limit with time to the end of the specified session. This is a rather dangerous operation, and will need a lot testing for different situations, Especially when the session does not belong to the user since I am allowing users in administrator group to do that so that settings can be propagated to new users.
Possible problem is when the user that needs settings reversal (target user) has changed the settings but the one the settings are imported from has not done so. Current algorithm does not import admin default preset if the source user has never changed the settings. It does not check on the target user.
A side effect of the feature is a new session is added in the importing process.
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Amber Herold
r16332 correct the problem mentioned in the last update. This feature is now completed.
Amber, assign Melody to test.
Testing:
1. Start a new Leginon session as a user, such as Anchi Cheng (It is my test user, I can fix whatever goes wrong if any). And start MSI-T application (any variety).
2. Check the settings in Exposure Node. The preset should be 'en' in there. Close Leginon.
3. Go to betamyamiweb/admin.php and click on Revert Settings.
4. Choose the user who you are testing (Anchi Cheng in this case), and 11nov28c session.
5. Click on "Revert Node Settings".
6. Start Leginon again as the same user, go back to the same session you started in step one and the same application to check the settings in Exposure Node. The preset should now be 'ed'.
- Assignee changed from Amber Herold to Anchi Cheng
Changes made to getSessionInfo() seem to be slowing down this query a lot, which is really noticable from getProject.php when there are many sessions in the Project. The issue for this is #1720.
Anchi, I'm thinking is might be much faster for you to fix this one right now, so I'll assign this issue to you.
- Assignee changed from Anchi Cheng to Amber Herold
Indeed it is faster for me to fix it. Sorry for the mess. It is caused by != in the query. getSessionInfo is used at too many places. r16499
- Status changed from In Code Review to Closed
Also available in: Atom
PDF