Project

General

Profile

Forums » Appion and Leginon Web tools »

Use of PHP short tags

Added by Christopher Lilienthal about 7 years ago

Hello,

Is there a plan to migrate away from using PHP short tags in favor of the long tag? I'd rather not enable short tags with PHP since it can interfere with XML scripts and it would not surprise me if PHP drops support for the short tags in the near future.

It appears that at least one PHP file in myami v3.2 uses both


Replies (7)

RE: Use of PHP short tags - Added by Anchi Cheng about 7 years ago

We will have to put someone on it. It is on our mind for years but could not face the task.

RE: Use of PHP short tags - Added by Christopher Lilienthal about 7 years ago

Hi Anchi,

I think I've changed all the tags in myami 3.2 in my copy of the source code. Is there any way for me submit my changes as a pull request?

RE: Use of PHP short tags - Added by Sargis Dallakyan about 7 years ago

Hi Christopher,

I've added you to our git project and you'll be able to git clone and push using your redmine login and password - http://emg.nysbc.org/issues/4136

Please make changes in the trunk as we are no longer using myami 3.2 for development.

Thanks,
Sargis

RE: Use of PHP short tags - Added by Christopher Lilienthal about 7 years ago

Hi Sargis,

I made the commits and although I included detailed (Perhaps too detailed) commit messages the web interface for the repository only shows a small portion of the message. I don't think it like me putting

RE: Use of PHP short tags - Added by Sargis Dallakyan about 7 years ago

Hi Christopher,

Thanks. It might be related to IDE you are using. I had similar problem with old version of Eclipse/eGit (couldn't add long commit messages). In any case, make sure you do git pull before git push to avoid push --force.

RE: Use of PHP short tags - Added by Christopher Lilienthal about 7 years ago

Hmm... That very well may be the source of the issue.

My apologies for the force push it will not happen again. Having said that do you normally just push to trunk or would you prefer pull requests?

RE: Use of PHP short tags - Added by Sargis Dallakyan about 7 years ago

Thanks for taking time to commit these changes. We haven't done pull requests, as far as I know, and have no one designated to handle pull requests.

    (1-7/7)