Project

General

Profile

Actions

Bug #1699

closed

appion setup.py default propogates files in /usr/bin

Added by Anchi Cheng over 12 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Amber Herold
Category:
Installation
Target version:
Start date:
04/09/2012
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

This causes easy explosion of files in the common /usr/bin/ accidentally, and the files it installed from appion/bin don't start with 'ap'.

Actions #1

Updated by Jim Pulokas over 12 years ago

  • Status changed from Assigned to In Test
  • Assignee changed from Jim Pulokas to Anchi Cheng

r16465 adds a warning if the user did not specify a command line option for the script destination.

Actions #2

Updated by Anchi Cheng over 12 years ago

  • Category set to Installation
  • Status changed from In Test to Assigned
  • Assignee changed from Anchi Cheng to Jim Pulokas

Could you work on install/centosAutoInstallation.py so that appion installation is put to more sensible place. I see that in there EMAN and Spider are in /usr/local. I think Appion should do the same with its own /etc/profile.d/ item. My do remember, though that since appion starts with 'a', it would be the first to execute, and it might end up at later part of path when others want to set to the head of the $PATH.

Your yes/no question will probably stop autoinstaller?

Actions #3

Updated by Jim Pulokas over 12 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Jim Pulokas to Anchi Cheng

r16478: as long as we specify "--install-scripts", then setup.py will not complain, so I added this to centosAutoInstallation.py. It will figure out the default bin directory (usually /usr/bin) and then create a subdirectory "appion" below it. It will also create appion.sh and appion.csh in profile.d which add this new directory to PATH.

For now I let python packages get installed in the default location (usually /usr/lib/python.../site-packages) because this is easier and does not require any additional PYTHONPATH. I thought about forcing it to /usr/local, but this only seems appropriate if the user gets to decide this. If they are out of the loop, it seems better to put it where python normally puts it.

Actions #4

Updated by Anchi Cheng over 12 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Anchi Cheng to Amber Herold

Looks good.

Amber, this can be tested when we get to try auto installation.

Actions #5

Updated by Amber Herold over 10 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF