Project

General

Profile

Actions

Bug #1737

closed

Refactor how we manage publication references

Added by Amber Herold over 12 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
Web interface
Target version:
Start date:
04/17/2012
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

It is blah. Make it less blah.


Related issues 1 (0 open1 closed)

Related to Appion - Bug #1736: Update the Data Collection Info reported for exemplars with new methodsClosedAnchi Cheng04/17/2012

Actions
Actions #1

Updated by Amber Herold over 12 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Amber Herold to Anchi Cheng

This is still in progress but would liuke feedback as we are branching tomorrow...
Need to add getters and also move more of the publications to the array...but that can happen more gradually.

Actions #2

Updated by Amber Herold over 12 years ago

r16520 actually belongs to #1736

Actions #3

Updated by Anchi Cheng over 12 years ago

  • Status changed from In Code Review to Closed

reviewed and liked it.

Actions #4

Updated by Anchi Cheng over 12 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from Anchi Cheng to Amber Herold

Found more files needing change by 'grep showReference *.php'

prepRefineForm.php: echo showReference($_POST['method']);
prepRefineForm.php: $headinfo .= showReference( $_POST['method'] );
selectModelForm.php:
selectPreparedRecon.php: $html.= $selectedRefineForm->showReference();
selectPreparedRecon.php: $headinfo .= showReference( $method );
selectStackForm.php:
uploadrecon.php: echo showReference( $method );
uploadrecon.php: $headinfo .= showReference( $method );

Actions #5

Updated by Amber Herold over 12 years ago

  • Target version changed from Appion/Leginon 2.2.0 to Appion/Leginon 3.0.0

This is mostly in place. Just need to continue process aof moving existing references over to the new method.

Actions #6

Updated by Amber Herold over 11 years ago

  • Status changed from Assigned to Closed

This is well established now.

Actions

Also available in: Atom PDF