Project

General

Profile

Actions

Feature #230

closed

add particle labels to pipeline

Added by Neil Voss over 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Category:
-
Target version:
Start date:
03/19/2010
Due date:
% Done:

100%

Estimated time:

Description

particles will be assigned a label and then one can select which label they want to use in makestack.

Denis has implemented this in ManualPicker at NIS and put the code into subversion. See r13237 and r13238.

I thought the makestack interface was cluttered and moved some fields, see r13242.

Next I need to put label into DoG Picker and template Correlator, maybe TiltPicker, but I am not sure about TiltPicker.

Actions #1

Updated by Neil Voss over 14 years ago

Jim added the code in r12989. Should we get rid of multipicker.py just use manualpicker.py with the extra code?

Actions #2

Updated by Neil Voss over 14 years ago

We need to merge multipicker.py with manualpicker.py and also get the updated manualpicker.php code from NIS.

Actions #3

Updated by Neil Voss over 14 years ago

  • % Done changed from 40 to 80
Actions #4

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Jim Pulokas

We need to copy of mutlipicker.py or whatever.

Actions #5

Updated by Neil Voss over 14 years ago

  • Target version set to Appion/Leginon 2.1.0
Actions #6

Updated by Anchi Cheng about 14 years ago

A lot of viewer-related changes are committed in r14748 to make the labeled particles to show up with different colors. These are what Denis have at NIS and there are still minor bugs that we will have to work on separately.

runManulpicker.php still needs to be modified to run the labeled picking.

Actions #7

Updated by Anchi Cheng about 14 years ago

merge multipicker.py function into manualpicker.py in r14751 so that the later can be removed once tested.
r14752 contains myamiweb changes to make it possible to use it in manual picking
r14753 contains a typo correction

Also make it possible to edit old unlabeled picks by assigning label to it if label is option is activated. If the old pick has labels, label option must be on and contains the old labels.

Actions #8

Updated by Anchi Cheng about 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Jim Pulokas to Eric Hou

Hi, Eric,

Could you do code review on the myamiweb-side (r14748, r14752). These are Denis's code and a lot of changes. Please pay attention that I have not revert some fixes you have added previously.

You can assign someone else such as Jim to code-review the python side.

Anyone can test.

Testing:
1. from a session run Manual Particle Pick with label added. You can add multiple labels.
2. Once completed, visit any image viewer and activate particle display by clicking "P".
3. Open particle display option tab (the down arrow right of the "P" icon ).
4. Choose to color by label, and select the labels to be displayed, change diameter of the individual labeled particles.
These should work. The display by threshold does not work on manually picked particle, though.

Actions #9

Updated by Eric Hou about 14 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Eric Hou to Amber Herold
  • % Done changed from 80 to 100
Actions #10

Updated by Amber Herold about 14 years ago

  • Status changed from In Test to Closed
Actions

Also available in: Atom PDF