Project

General

Profile

Actions
Copy link

Bug #2429

closed

ready to upload count in processing menu for refinement job is not correct

Added by Anchi Cheng over 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
High
Assignee:
Anchi Cheng
Category:
-
Target version:
Appion/Leginon 3.0.0
Start date:
07/19/2013
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 2.1.0
Show in known bugs:
No
Workaround:

Description

Example:

checkRefineJobs.php?expId=9318&type=single

There is only one run for upload when I looked using the page but the processing menu counted 19. I suspect that it counts the uploaded ones (12) as well.

Actions
Copy link
 #1

Updated by Amber Herold over 11 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Amber Herold to Anchi Cheng

This is fixed by checking if the job has been uploaded or aborted and not checking if there is an associated job file in the refineJobs class. In the php display page, we issue a warning if there is no job file. The problem came about because there are 2 similar functions in the refineJobs class, getRefinesReadyToUpload() and getUnfinishedRefineJobs(). The menu is using one and the display the other. The display uses getUnfinishedRefineJobs() which also returns jobs that are currently running and are not quite ready to upload. This way we can check their status. The menu uses getRefinesReadyToUpload() as it is a more accurate count.

Actions
Copy link
 #2

Updated by Anchi Cheng about 11 years ago

  • Status changed from In Code Review to Closed

code is good and tested

Actions
Copy link

Also available in: Atom PDF