Bug #2517
closedCorrector instruments in settings gui does not match what Leginon think it is on when initialized
0%
Description
Instrument in settings are typically shown as the one last loaded but GetValue of the widget gives what is last saved in the database. This is because Loading instrument often is delayed so that the widget was already set.
This causes a confusion since we will see the last loaded instrument selected but when we close the settings dialog and collect the reference image, they would be of the instrument in the database since the instrument are not set when the dialog is closed but are set when the selector choice is changed.
This problem was not obvious until we start having multiple camera on the same scope and different tem classes set for regular TEM vs EFTEM.
Updated by Anchi Cheng over 10 years ago
r17888 sets the values of the instruments with the widget values. This forces all values become the database values unless the database instrument is not available to the Leginon session, in which case None is given. At least it is consistent so the users will know it.
This change are applied to 2.2 as r17889 and to 2.2-redux as r17890
Updated by Anchi Cheng over 10 years ago
- Category set to Leginon GUI
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Jim Pulokas
- Target version set to Appion/Leginon 3.0.0
Scott tested it for issue #2516 and it worked.
Updated by Anchi Cheng over 10 years ago
r17899,r17900,r17901 fixes the None assignment bug introduced by this.
Updated by Anchi Cheng over 10 years ago
- Status changed from In Code Review to Closed
- Assignee changed from Jim Pulokas to Anchi Cheng
No one to review. Tested.