Project

General

Profile

Actions

Bug #2657

closed

new appionloop form dose not give any preset selection when there is no en preset

Added by Anchi Cheng almost 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Category:
Web interface
Target version:
Start date:
02/11/2014
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.0.0
Show in known bugs:
No
Workaround:

Description

The form creation default to en preset which does not exist in presetList that has only one item.

As a result valid preset does not show up when there is single selection since $preset is not defined locally in generateForm

I didn't check but it might also be broken when there is multiple selection but en does not exist.

Please fix now. Example session: 14jan02w

Liz can test.

Actions #1

Updated by Amber Herold almost 11 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Amber Herold to Anchi Cheng

There was bad array access code. Fixed.
The default preset value of "en" is not actually being used yet, so should not have an effect. Would be nice to be able to set a default value though, so will keep that in mind.

Will be ready to test when myamiweb is updated tomorrow morning.

Actions #2

Updated by Anchi Cheng about 9 years ago

  • Status changed from In Code Review to Closed
Actions

Also available in: Atom PDF