Bug #267
closedRun name numbers should increment by type not tool
100%
Description
I think the runnames should go like
dogrun1, tmplrun2, dogrun3, tiltrun4, tmplrun5, etc.
NOT
dogrun1, tmplrun1, dogrun2, tiltrun1, tmplrun2, etc.
We can debate this if you want to change it back.
Updated by Neil Voss over 14 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Neil Voss to Amber Herold
- % Done changed from 0 to 100
changed to do this, it's a quick fix to revert.
Updated by Amber Herold over 14 years ago
- Assignee changed from Amber Herold to Neil Voss
Neil,
This name is confusing: getLastRunNumberType
It returns a number rather than a type, correct?
Also, why does runMaskMaker.php still use getLastRunNumber()?
If you need to keep both functions available, it would be nice to provide function headers explaining the difference.
It seems to me that the original function is more precisely getting the run number by run type and the new one is more general.
Updated by Neil Voss over 14 years ago
- Assignee changed from Neil Voss to Amber Herold
In r13458, I changed getLastRunNumberType() to getLastRunNumberForType(), so it makes sense that would return a number not a type, we could also use getLastRunNumberForRunType().
I did not change Mask programs, because I know little about them and I am not even sure if they currently work.
Updated by Amber Herold over 14 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Amber Herold to Neil Voss
Updated by Neil Voss over 14 years ago
- Assignee changed from Neil Voss to Dmitry Lyumkis
Updated by Neil Voss over 14 years ago
- Target version set to Appion/Leginon 2.0.0
Updated by Neil Voss over 14 years ago
- Assignee changed from Dmitry Lyumkis to Anke Mulder
Dmitry is gone.
Updated by Anke Mulder over 14 years ago
- Status changed from In Test to Closed
The incrementing works as suggested now.