Project

General

Profile

Actions

Bug #2936

closed

Svn rev 18580: DM_VERSION harcoded in pyscope/dmsem.py

Added by Tom Houweling about 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
09/22/2014
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.1.0
Show in known bugs:
No
Workaround:

Set DM_VERSION to 2.31.xxxx


Description

After upgrading to DM 2.31 streaks appeared in normalized images/movies. After analyzing the issue we found that normalization images were applied erroneously due to the hardcoded setting in dmsem,py which forces version 2.30 causing different behavior.

The issue is that all appeared to work fine at first and that two sessions were collected with the wrong version and it took another two days to find this setting.

It would be better to obtain the version from DM and report the found version and/or have the version not set in the committed file, reminding the installer that it must be set to the correct version of Digital Micrograph.

Actions #1

Updated by Anchi Cheng about 10 years ago

  • Assignee set to Anchi Cheng

Tom,

Actually I've tried getting the version through SERIALEMCCD. Unfortunately, its output for 2.30 gave non-sense version number, so I had to use the hard-code as work around. I now have a separated way to get DM version. I will give that a try and move the configuration out of the file.

You made a very good point that I could have leave it blank and force installer to set it.

Actions #2

Updated by Anchi Cheng almost 7 years ago

  • Status changed from New to Closed
  • Target version set to Appion/Leginon 3.2

dmsem.cfg fixed this.

Actions

Also available in: Atom PDF