Project

General

Profile

Actions

Bug #2951

closed

error in calculating raster spacing and angle with image shift as move type in raster finder

Added by Anchi Cheng about 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
10/07/2014
Due date:
% Done:

0%

Estimated time:
Affected Version:
Appion/Leginon 3.0.0
Show in known bugs:
No
Workaround:

Description

Reported by Thorsten Mielke

After updating to 3.1, I observed a new problem with exposure targeting in the MSI-raster application. Sub-square targeting works fine (sq=560x mag, hl=4400x mag). However, when calculating the final exposure targets (hl=4400x mag, ef=15000x mag or higher), Leginon gives the following error while calculating the spacing and angle for the ef-preset:

Traceback (most recent call last):
File "/usr/local/LEGINON/Python/lib/python2.7/site-packages/leginon/gui/wx/RasterFinder.py", line 228, in onAutoButton
s,a = self.node.autoSpacingAngle()
File "/usr/local/LEGINON/Python/lib/python2.7/site-packages/leginon/rasterfinder.py", line 108, in autoSpacingAngle
p2 = self.calclients[movetype].pixelToPixel(tem, cam, ht, mag1, mag2, p1)
TypeError: pixelToPixel() takes exactly 9 arguments (7 given)

Actions #1

Updated by Anchi Cheng about 10 years ago

This is a three-year-old bug that wasn't discovered until now. pixelToPixel for image shift was changed to accomodate multiple camera but not so with other move type in matrix calibration.

r18609 fixes it in trunk
r18611 fixes it in 3.1

Actions #2

Updated by Anchi Cheng about 10 years ago

  • Status changed from Assigned to In Test
  • Assignee changed from Anchi Cheng to Thorsten Mielke

Please test

Actions #3

Updated by Anchi Cheng almost 7 years ago

  • Status changed from In Test to Closed
  • Target version set to Appion/Leginon 3.1.0
Actions

Also available in: Atom PDF