Bug #2989
openbasicScript.BasicScript wait time is unhelpful
0%
Description
Scott and I have noticed that basicScript.BasicScript often stops scripts from running because of the built in wait time at line 42:
if loadavg > 2.0:
apDisplay.printMsg("Load average is %.2f, wait for %.1f second " % (round(loadavg,2),loadavg**2))
time.sleep(loadavg**2)
apDisplay.printMsg("Load average is high "+str(round(loadavg,2)))
This condition seems like a relic from the days when processors only had one or two cores. It only serves as an impediment to processing data in our lab.
We're opting to remove it on our end. Who is in favor of removing this from the next release version?
Updated by Sargis Dallakyan almost 10 years ago
- Status changed from New to In Code Review
Thanks. Commented out sleep time in r18693.
Updated by Anchi Cheng almost 10 years ago
Neil,
Can we get rid of it rather than commenting it out ? Do you still want the block of code there ?
Updated by Neil Voss almost 10 years ago
I don't care, we can remove it.
It was added when we were getting situations where the load would be like 200 and the machine would crash. The idea was a small load wait would allow the machine to catch. Perhaps it should not be the square of the load, but it save some crashing during early development.
Updated by Alex Noble almost 10 years ago
I just realized that the wait code is replicated in the close() function around line 100 in basicScript. We should do away with that too.
Updated by Bridget Carragher over 9 years ago
Did this replicate get resolved before the systems went down?