Project

General

Profile

Actions

Bug #353

closed

Upload image can upload images with same names as other sessions

Added by Neil Voss over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
04/15/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Show in known bugs:
Workaround:

Description

Program should query the DB, and if name exists append session name to the front

Actions #1

Updated by Neil Voss over 14 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Neil Voss to Amber Herold

other modifications came with it. Hard to test if not uploading images.

Actions #2

Updated by Amber Herold over 14 years ago

  • Assignee changed from Amber Herold to Neil Voss

Line 249: time.sleep(load) in Image loader, I very much dislike any call to sleep in any code unless it is absolutely necessary. My particular problem with this one is that it does not seem to enforce an upper bound to the amount of time that it could sleep.

Can you add an upper bound?

Actions #3

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Amber Herold

I added the upper bound in r13871. Probably not necessary, because if your load is larger than the number of processors, you have other problems you need to fix.

Actions #4

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Amber Herold to Neil Voss

Who to test?

Actions #5

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Anchi Cheng
Actions #6

Updated by Anchi Cheng over 14 years ago

  • Assignee changed from Anchi Cheng to Neil Voss

What am I testing exactly? Sleeping? loading images of the same name?

Actions #7

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Anchi Cheng

Sorry, if you upload images it should add the new session name to the front of the image.

Actions #8

Updated by Neil Voss over 14 years ago

  • Target version set to Appion/Leginon 2.0.0
Actions #9

Updated by Anchi Cheng over 14 years ago

  • Status changed from In Test to Closed
Actions #10

Updated by Neil Voss over 14 years ago

  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF