Bug #393
closedgetproject.php get wrong experiments in the summary
100%
Description
The experiment shown in project/getproject.php is not consistent with the experiments below to the project
Updated by Neil Voss over 14 years ago
Can you provide an example it works for me.
Updated by Anchi Cheng over 14 years ago
The original uses an array containing both projectdata.projectexperiments.projectexperimentId and projectdata.projectexperiments.name for searching SessionInfo in leginondata. Because the former is not the same as leginondata.SessionData.DEF_id all the time, the query gives the wrong result when the two are out of sync. Until we make projectdata.projectexperiments a sinedon formated table that no longer uses projectexperimentId, the query can only be achieved correctly by name only.
Refs. Revision r13641
Testing:
1. Create a Leginon session that does not belong to any project:
This happens when we import default settings tables for leginon by-
(a) go to /myamiweb/addsettings.php
(b) click on Load
2. Create a Leginon session in a project by uploading images to a new session or running a Leginon session
3. goto /myamiweb/project.php and choose the same project.
The new session should show up in the project even though its projectexperimentId is off from leginondata.SessionData.DEF_id
Updated by Anchi Cheng over 14 years ago
- Status changed from New to In Code Review
- Assignee changed from Anchi Cheng to Eric Hou
Found an example where it went wrong with the live database.
http://cronus3.scripps.edu/myamiweb/project/getproject.php?projectId=209
With the old code, we get 10jan11anchiA7 as one of the experiment belongs to the project. This is incorrect.
With the new code, we get 10jan13a.
It turns out the getSessionInfo function in myamiweb/inc uses OR. which is why it did not fail as often as it would be.
Updated by Eric Hou over 14 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Eric Hou to Amber Herold
looks good to me.