Project

General

Profile

Actions
Copy link

Bug #479

closed

add application version number in the database.

Added by Eric Hou over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Anchi Cheng
Category:
-
Target version:
Appion/Leginon 2.0.0
Start date:
05/14/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
Show in known bugs:
Workaround:

Description

We have decided to put Appion/Leginon version number in the project database "install" table.
This need to be done in three places.

1. the database upgrade script from very old to 1.6.
2. the database upgrade script from 1.6 to 2.0
3. The new database initialization.

Thanks.

Actions
Copy link
 #1

Updated by Eric Hou over 14 years ago

  • Status changed from New to In Code Review
  • Target version set to Appion/Leginon 2.0.0
  • % Done changed from 0 to 100

add the version number in Project database in all the upgrade scripts and database initialization xml file.

To test this. you need all different type of the version of database schema. and run the db upgrade scripts.
Search intall table in the project database. You should see the version number in the table.

Thanks.

r13932
r13937

Actions
Copy link
 #2

Updated by Eric Hou over 14 years ago

  • Assignee changed from Eric Hou to Amber Herold
Actions
Copy link
 #3

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to In Test
  • Assignee changed from Amber Herold to Anchi Cheng
Actions
Copy link
 #4

Updated by Anchi Cheng over 14 years ago

  • Assignee changed from Anchi Cheng to Eric Hou

Eric's update wizard enter the version value as 2.0 Then Neil's first schema update script changes it back to 1.7 and then the second changed to 2.0. Maybe the wizard need to put a different version number there?

The route where no 'version' is found in the 'install' table, it
insertq = "INSERT INTO `install` (`key`, `value`) VALUES ('version', '1.7')"
projectdb.executeCustomSQL(insertq)

An error occurs:
traceback (most recent call last):
File "./schema-r12857.py", line 289, in <module>
projectdb.executeCustomSQL(insertq)
File "/Users/acheng/myami/sinedon/dbupgrade.py", line 294, in executeCustomSQL
self.executeQuery(query)
File "/Users/acheng/myami/sinedon/dbupgrade.py", line 70, in executeQuery
if messaging[querytype+' query'] is True:
KeyError: 'insert query'

This route should not occur anyway since the wizard does enter a version.

Actions
Copy link
 #5

Updated by Anchi Cheng over 14 years ago

a bug is fixed during the testing in schema-r12857.py by r14032 for not running the version update, but thought I fixed it by changing = to like. That part is reverted in r14033.

Actions
Copy link
 #6

Updated by Eric Hou over 14 years ago

  • Assignee changed from Eric Hou to Anchi Cheng

Just change the projectUpdateValues.xml to version number 1.7
And change schema-r12857.py to version number 1.8.
And schmea-r13713.py stay in 2.0.
So they don't have conflict now.

Thanks.

Eric

Actions
Copy link
 #7

Updated by Eric Hou over 14 years ago

above change:
r14052 , r14053

Actions
Copy link
 #8

Updated by Anchi Cheng over 14 years ago

  • Status changed from In Test to Closed

since another schema update schema-r14077.py (refs. r14096) is added, the version number for schema-r13713.py is changed to v1.9 in r14098. Tested by updating Scott's datbase. All versions are inserted correctly

Actions
Copy link

Also available in: Atom PDF