Bug #486
closedappion tables not initialized
100%
Description
Weren't we going to create all appion processing tables as part of processingdb creation. Example of the bug:
New processing db ap267 was created on 13th of may. I ran ace2 but not ace. Now I can't see acerun parameters after the runs when I click on the runname.
Updated by Neil Voss over 14 years ago
Run the maketables.py script on an empty database and dump the XML file.
Updated by Anchi Cheng over 14 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Neil Voss to Eric Hou
- % Done changed from 0 to 100
Neil created appion database schema through sinedon/maketables.py --xml-file=appion.xml --sinedon-name=appiondata
--module-name=appionlib.appiondata. The overlapping table definition that is in defaultprocessingtable.xml is removed in appion.xml and the file renamed to xml/appion_extra.xml. sinedon does not generate type varchar of the specific length so if it is better to be so, the definition is left in defaultprocessingtable.xml.
Also, ApTIltsInAlignRunData has a field called 'primary' that it caused an error in insert. This is also fixed in appion_extra.xml
The related changes are in r14016.
Ideally, a script should do these editing, but this will do for now. I will file another bug to rename the ApTiltsInAlignRunData column 'primary' and update database for that later.
Updated by Eric Hou over 14 years ago
Maybe this is the way it is now, but why can't we combine the 'defaultprocessingtables.xml' and 'appion_extra.xml' so it does not need to import twice?
Thanks.
Eric
Updated by Anchi Cheng over 14 years ago
Because defaultprocessingtable.xml can't be generated from the script that generates appion_extra,xml until we have a better fix in sinedon.
Updated by Eric Hou over 14 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Eric Hou to Amber Herold
discuss with Anchi about the code.
Everything is fine now.
Eric
Updated by Amber Herold over 14 years ago
Anchi, Eric, What is the test procedure?
Updated by Amber Herold over 14 years ago
- Assignee changed from Amber Herold to Anchi Cheng
Updated by Anchi Cheng over 14 years ago
- Assignee changed from Anchi Cheng to Amber Herold
Testing from myamiweb/project/
1. create a new project
2. click on the new project name to view the summary of the project in myamiweb/project/getproject.php
3. link the project to a new processingdb
4. check the number of tables created in the new processingdb. With the dfaultprocessingtables.xml only, it will have a small number ( about 10) of tables. WIth appion_extra.xml, it will have the number of the current appiondata.py classes.
see #522 for how appion_extra.xml is created.