Bug #542
closed
despike does not work any more
Added by Anchi Cheng over 14 years ago.
Updated almost 14 years ago.
Affected Version:
Appion/Leginon 2.1.0
Description
correctorclient has a deactivated despiking function. Realized today that there are people out there could not live without it with higher voltage electron
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Jim Pulokas
- % Done changed from 0 to 100
Use CorrectorPlanData to save despike parameter so that correctorclient can use it. Therefore, the option is now tied with camera settings. Tested with simulation
- Status changed from In Code Review to In Test
- Assignee changed from Jim Pulokas to Anchi Cheng
you probably already tested, so close it if you think it is ok. That looks good, the way you put it back in there using the corrector plan, as long as people understand (through good documentation) that this is a "per camera setting" option and not a "per node" or "per preset" type setting like maybe it could be some day. We also need to make it clear that despike can really mess up your images if you give it bad parameters. That was one of the reasons for disabling it, in addition to trying to save time on the big images. At one time, it would actually print out how many pixels it was despiking, so you could see if it was out of control. Maybe some day we can make the algorithm better to ensure we are only removing spikes rather than smoothing out legitimate local maxima in the data.
- Status changed from In Test to Closed
- Affected Version set to Appion/Leginon 2.1.0
- Show in known bugs set to No
Also available in: Atom
PDF