Bug #631
closedsubStack.py default params['first'] to 0 not 1
0%
Description
noticed this. SInce 'first' is Spider particle counting, it should start from one. I didn't find it through running the script, so I don't suppose there is a test procedure.
Updated by Anchi Cheng over 14 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Amber Herold
- Target version set to Appion/Leginon 2.0.1
committed to trunk as r14286. This default might never be used.
Updated by Amber Herold over 14 years ago
- Assignee changed from Amber Herold to Neil Voss
Neil, it looks like you were the last person to edit this line of code. Can you confirm that Anchi's change is correct? I'm not sure that it is worth moving to the branch right now since there is not much time for testing and there is no real test procedure for this. I'm leaning toward leaving it on the trunk only.
Thoughts?
Updated by Neil Voss over 14 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Neil Voss to Anchi Cheng
looks okay to me. This fix should not be met under normal conditions. It only applies when --last is specified without a --first, which is rare. So, no merge is necessary.