Project

General

Profile

Actions

Bug #65

closed

Users should not be allowed pick particles outside of the image.

Added by Neil Voss almost 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amber Herold
Target version:
Start date:
01/28/2010
Due date:
% Done:

100%

Estimated time:
0.10 h
Spent time:

Description

In the TiltPicker, it is possible to pick particles outside of the image. Normally, this is not a problem except that you cannot easily remove these erroneous picks.

I propose that the picks either (1) be rejected in the ImagePanel onClick function or (2) be cleared when the onApply button is pushed.

This is not a general feature for the ImagePanel, because in Leginon it is desirable to pick outside the image when using the navigator.

But this could also be applied to the ManualPicker.

source:trunk/appion/bin/manualpicker.py
source:trunk/appion/bin/ApTiltPicker.py


Related issues 1 (0 open1 closed)

Related to TiltPicker - Bug #418: TiltPicker does not allow picking on entire rectangular imageClosed05/03/2010

Actions
Actions #1

Updated by Neil Voss almost 15 years ago

  • Status changed from Assigned to In Code Review
  • Assignee changed from Neil Voss to Amber Herold
  • % Done changed from 0 to 100
  • Estimated time set to 0.10 h

This bug is fixed for ApTiltPicker (r13037) and manualpicker (r13038).

Tested in the GUI for both programs.

Actions #2

Updated by Amber Herold over 14 years ago

Why do you check for x and y > 2 rather than 0 or 5 or something else?

Actions #3

Updated by Amber Herold over 14 years ago

  • Assignee changed from Amber Herold to Neil Voss
Actions #4

Updated by Neil Voss over 14 years ago

  • Assignee changed from Neil Voss to Amber Herold

you are picking the center of the particle, so pixel zero is too close to the edge. I thought 5 pixels would be too much, so I choose 2. The most mathematically pleasing choice would be 0, but the user cannot tell the difference between 0 and 2 in the GUI.

Actions #5

Updated by Neil Voss over 14 years ago

  • Project changed from Appion to TiltPicker
  • Category deleted (3)
Actions #6

Updated by Neil Voss over 14 years ago

  • Target version set to TiltPicker v2.0
Actions #7

Updated by Amber Herold over 14 years ago

  • Status changed from In Code Review to Closed
Actions

Also available in: Atom PDF