Bug #782
closedearly dbem_1_5_0 upgrade imageviewer query for image filenames fails
100%
Description
schema upgrade did not create leginondb.ViewerImageStatus table
Updated by Anchi Cheng over 14 years ago
- Status changed from Assigned to In Code Review
- Assignee changed from Anchi Cheng to Amber Herold
- % Done changed from 0 to 100
dbem_1_5_0 at one point was released without viewer_pref table creation because it was not a released feature. Users with that version (Most Leginon 1.6 users who didn't try out Appion 1.0), would have such a situation.
Without viewer_pref table, dbschema/schema-r13713.py fails to rename it to ViewerImageStatus. Unforturnately there is no error message, it also did not run schema update after the failed query so that leginondb.PresetData.exposure_time was not changed from int to double.
Fix it with a check on existing viewer_pref table and creates alternative route in the case that it does not. Revision r14564
Testing:
1. take a 1.7 upgraded database set, remove viewer_pref table if it has one, then run schema-r12857.py and schema-r13713.py
2. ViewerImageStatus table should appear.
This need to be in the branch 2.0 because the side effect of failed PresetData type change will cause fatal Leginon running problem.
Updated by Amber Herold over 14 years ago
- Status changed from In Code Review to In Test
- Assignee changed from Amber Herold to Anchi Cheng
Anchi, do you have access to dbs to test? I can run it, but need a few dbs to cover different cases.
Seems like we need a common place to put dbs that we can use specifically for testing. WHat do you think?
Updated by Anchi Cheng over 14 years ago
- Status changed from In Test to Closed
Put some database examples in /amishare/myamiSampleDatabases. README files are included for each set explaining the specificity and oddity of them.